Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at moving 'Mijn Berichten' into a CMS apphook #584

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Bartvaderkin
Copy link
Contributor

Same as the other first-passes:

I kept the views and tests at their current sub-optimal locations and basically moved the urls.

Most of the changes are because this changed the url namespace.

@codecov-commenter
Copy link

Codecov Report

Merging #584 (aaebae0) into feature/django-cms (398c808) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           feature/django-cms     #584      +/-   ##
======================================================
- Coverage               96.71%   96.70%   -0.02%     
======================================================
  Files                     552      555       +3     
  Lines                   19481    19510      +29     
======================================================
+ Hits                    18842    18867      +25     
- Misses                    639      643       +4     
Impacted Files Coverage Δ
src/open_inwoner/accounts/tests/test_auth.py 100.00% <ø> (ø)
src/open_inwoner/accounts/urls.py 100.00% <ø> (ø)
src/open_inwoner/accounts/views/__init__.py 100.00% <ø> (ø)
.../open_inwoner/components/templatetags/link_tags.py 92.72% <ø> (ø)
src/open_inwoner/conf/base.py 95.37% <ø> (ø)
...ounts/management/commands/notify_about_messages.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/models.py 97.91% <100.00%> (ø)
src/open_inwoner/accounts/tests/test_admin.py 100.00% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_contact_views.py 100.00% <100.00%> (ø)
...rc/open_inwoner/accounts/tests/test_file_upload.py 100.00% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin force-pushed the feature/django-cms-inbox branch 2 times, most recently from a85c295 to 9cc5356 Compare April 17, 2023 08:08
@Bartvaderkin Bartvaderkin force-pushed the feature/django-cms-inbox branch from 9cc5356 to 081cb91 Compare April 17, 2023 14:39
@Bartvaderkin Bartvaderkin marked this pull request as ready for review April 17, 2023 14:39
@Bartvaderkin Bartvaderkin merged commit ecee4d6 into feature/django-cms Apr 17, 2023
@Bartvaderkin Bartvaderkin deleted the feature/django-cms-inbox branch April 17, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants