Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1364] Add django log outgoing requests library #582

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 13, 2023

No description provided.

@vaszig vaszig changed the title [#1364] Add django outgoing requests library [#1364] Add django log outgoing requests library Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #582 (c44a7ab) into develop (6491d69) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #582      +/-   ##
===========================================
+ Coverage    96.72%   96.73%   +0.01%     
===========================================
  Files          553      545       -8     
  Lines        19482    19330     -152     
===========================================
- Hits         18843    18698     -145     
+ Misses         639      632       -7     
Impacted Files Coverage Δ
src/open_inwoner/conf/base.py 95.23% <ø> (ø)
...rc/open_inwoner/haalcentraal/tests/test_logging.py 100.00% <100.00%> (ø)
src/open_inwoner/openzaak/tests/test_logging.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig requested a review from Bartvaderkin April 14, 2023 12:30
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great ratio of added-vs-removed code 😄

One cosmetic note, it'd be neater if we start to do cleaner PR/merges: like the "Trying to debug" and "Fixed tests" commits don't need to be in the git log forever.

Personally once I'm done with a thing and I'm the only one working on it I soft-reset the branch, make a clean commit and force-push it (if I wasn't doing Amend-Commit in the first place)

@vaszig vaszig force-pushed the feature/1364-add-django-outgoing-requests-library branch from ea8670b to c44a7ab Compare April 18, 2023 08:00
@vaszig vaszig requested a review from Bartvaderkin April 24, 2023 13:33
@alextreme alextreme merged commit 719aeff into develop Apr 28, 2023
@alextreme alextreme deleted the feature/1364-add-django-outgoing-requests-library branch April 28, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants