Migrate to Django-CMS #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0bda414 to
398c808
Compare
Codecov Report
@@ Coverage Diff @@
## develop #581 +/- ##
===========================================
- Coverage 96.76% 96.17% -0.60%
===========================================
Files 554 564 +10
Lines 19602 19795 +193
===========================================
+ Hits 18968 19037 +69
- Misses 634 758 +124
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alextreme
requested changes
Apr 17, 2023
1fa0b3b to
b62b6b8
Compare
3cd78ff to
f2370d5
Compare
alextreme
reviewed
Apr 24, 2023
| @@ -49,6 +49,17 @@ playwright | |||
| django-yubin | |||
| django-image-cropping | |||
|
|
|||
| # django cms | |||
| django-cms | |||
| djangocms-text-ckeditor | |||
There was a problem hiding this comment.
for now disable djangocms-text/link/file/picture
alextreme
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Can be merged, however a few remarks:
- lets remove the djangocms-x plugins for now before merging (to avoid having to style these properly, it'll be quite a bit of work)
- the 'fixed' home-templates are commentted out (which is useful for the transition but will need to be cleaned up later)
- See what's possible with a django cms fixture, but that can be done after merging on the testenvironment. Alternatives would be to use a wizard or setting up the various environments manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs a basic functional django-cms, using the regular templates.
This as a development basis to start building out and migrating existing apps and features to apphooks and plugins.
For now all new elements have a very ugly CSS style and outline (like the dynamic menu).
The existing homepage is moved to /oldhome so we can have django-cms as root in the url router. This also means url-resolving and reversing is a bit borky as existing urls take precedence.
(this also breaks dajngo-admin-index layout so that is disabled for now)