Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1258] Fix order of phonenumber and email in product locations #556

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Mar 24, 2023

I added some styling as well in order to comply with the project's link styles.
Let me know if you agree with that.

emailphone

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #556 (1c851d7) into develop (462a316) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #556      +/-   ##
===========================================
- Coverage    96.49%   96.47%   -0.02%     
===========================================
  Files          542      543       +1     
  Lines        19332    19374      +42     
===========================================
+ Hits         18655    18692      +37     
- Misses         677      682       +5     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig requested review from Bartvaderkin and jiromaykin and removed request for Bartvaderkin March 24, 2023 14:14
@vaszig vaszig requested a review from Bartvaderkin March 27, 2023 11:41
Bartvaderkin
Bartvaderkin previously approved these changes Mar 27, 2023
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alextreme alextreme merged commit d8a7f0f into develop Mar 27, 2023
@alextreme alextreme deleted the fix/1258-productlocation-phonenumber-email-order-and-make-them-clickable branch March 27, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants