💄 [#1132] Select-element caret for contacts-page #503

jiromaykin · 2023-02-27T12:57:52Z

select tag needs arrow/caret
https://taiga.maykinmedia.nl/project/open-inwoner/issue/1132

After discussing with Roxanne (designer):

translation/textually "soort contact" and "type contact" should be the same; so pick one and use consistently (TODO later in translations), either use "soort contact" everywhere, or use "type contact" everywhere.
align the Select element to the right
add icon with expand_more arrow/caret
discuss with designer if all filter-pages should look consistent
delete the old PR/branch due to mess with translations and wrong name there
refactor Filters section to look like all the others (like in Plans and Actions)

codecov-commenter · 2023-02-27T13:33:27Z

Codecov Report

Merging #503 (3e9c0f7) into develop (4b09a8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #503   +/-   ##
========================================
  Coverage    96.48%   96.48%           
========================================
  Files          527      527           
  Lines        19003    19003           
========================================
  Hits         18335    18335           
  Misses         668      668

Impacted Files	Coverage Δ
.../open_inwoner/components/templatetags/form_tags.py	`94.30% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/open_inwoner/scss/views/_view.scss

vaszig

It looks nice on desktop version but what about the mobile one? (there is no space between the two elements and is the select correctly aligned?)

jiromaykin · 2023-03-02T15:21:58Z

It looks nice on desktop version but what about the mobile one? (there is no space between the two elements and is the select correctly aligned?)

Thank you - for now I have changed this one to look more like the other pages that have a filter - but this means we are repeating the same pattern for Plans/Actions/Contacts - so in future I probably should refactor them into 1 single JS file (not sure yet...).

src/open_inwoner/templates/pages/profile/contacts/list.html

vaszig · 2023-03-03T08:33:36Z

src/open_inwoner/templates/pages/profile/contacts/list.html

+    <div class="contacts">
+        {% render_form id="contact-filter" form=form method="GET" no_actions=True horizontal=True spaceless=True autosubmit=True form_action=form_action class="form form--columns-2 form--spaceless form--autosubmit form--horizontal" %}
+            <div class="form__control contacts__filters">
+                <div class="contacts__filter-button">


It would be better to keep the names consistent. The parent is different from the child (contacts__filters and contacts__filter

:-D I was using the naming convention from the 'Actions' files open_inwoner/js/components/actions/index.js - where it seems a collection of filters is called as the multiple 'filters', but I can change this, no prob.
I will then also have to change this in the Actions files, or else we will have different conventions.

No problem then, you can keep it as is.

src/open_inwoner/templates/pages/profile/contacts/list.html

vaszig · 2023-03-03T08:36:08Z

Some of my comments should be present in my previous review but I was lost in the html changes (formatting) and didn't mention them.

…s option to TimelineLog admin

…page

jiromaykin · 2023-03-06T08:49:42Z

@vaszig @Bartvaderkin I was trying to solve a merge conflict by rebasing so hopefully this all went correct!
This looks a bit crazy now, with all the rebased commits, but my own code should be correct...

Bartvaderkin · 2023-03-06T08:55:09Z

@jiromaykin This rebase didn't really go as it should, your PR shouldn't list all other commits. Also merging from develop back into a feature branch is not what we'd like to see (this really messes with the git history).

If you can't fix this branch it is also an option to make a new branch and do things like Cherry-Pick from this, or if all else fails just manually copy your changes (using Browse At Revision).

jiromaykin · 2023-03-06T10:11:52Z

...it is also an option to make a new branch and do things like Cherry-Pick from this, or if all else fails just manually copy your changes (using Browse At Revision).

Thanks - this branch has become a mess so I will start a new one - sorry for this!

jiromaykin mentioned this pull request Feb 27, 2023

🎨 [#1132] Select-element for contacts-page design #477

Closed

5 tasks

jiromaykin marked this pull request as ready for review February 27, 2023 14:04

jiromaykin requested a review from Bartvaderkin February 27, 2023 14:04

Bartvaderkin suggested changes Feb 28, 2023

View reviewed changes

src/open_inwoner/scss/views/_view.scss Outdated Show resolved Hide resolved

🎨 [#1132] fixed alignment and add expand_more arrow icon for contacts

fddb998

jiromaykin force-pushed the feature/1132-select-element-for-contacts-page branch from 005898c to fddb998 Compare February 28, 2023 09:31

jiromaykin changed the title ~~🎨 [#1132] select-element caret for contacts-page~~ 🎨 [#1132] Select-element caret for contacts-page Feb 28, 2023

jiromaykin changed the title ~~🎨 [#1132] Select-element caret for contacts-page~~ 💄 [#1132] Select-element caret for contacts-page Feb 28, 2023

💄 [#1132] Changed select tag selector into input class selector for BEM

7c0cf13

jiromaykin requested a review from vaszig February 28, 2023 09:38

vaszig reviewed Feb 28, 2023

View reviewed changes

jiromaykin added 2 commits March 2, 2023 14:35

💄 [#1132] Refactored filter area for Select tag in Contacts

93d6f00

💄 [#1132] Reverted CSS to develop-branch version

57ecd8e

jiromaykin requested a review from vaszig March 2, 2023 15:22

vaszig requested changes Mar 3, 2023

View reviewed changes

jiromaykin marked this pull request as draft March 3, 2023 09:20

jiromaykin added 2 commits March 3, 2023 10:56

💄 [#1132] Removing unnecessary classes

6da9629

💄 [#1132] Formatting template

d789848

jiromaykin marked this pull request as ready for review March 3, 2023 14:24

jiromaykin and others added 8 commits March 5, 2023 14:42

💄 [#1132] Solve merge conflict

2f2ce65

[#1186] Hiding Geboorteland from Mijn Gegevens (BRP)

8d836a3

[#1158] Added image field for begeleider user

1802645

[#1158] Fixed field name

0930f71

[#1158] Updated image field name and tests

8804973

[#1158] Fixed migrations after rebase

bd74e19

[#1158] Fixed image name

c1e0afe

[#1163] Added optional banner to the plan list view

473ad1e

Bart van der Schoor and others added 18 commits March 5, 2023 14:55

Added 'log_action' list_filter to TimelineLog admin

1819545

Added custom 'content type' list_filter that only shows used record a…

2600092

…s option to TimelineLog admin

Fixed migrations conflict in configurations

8da5c3b

[#1156] Added email and phonenumber to map and location cards

ea5f878

[#1156] Fixed flexbox

45e795c

[#1156] Escape html

65851ec

[#1156] Updated map js imports

f6fde08

[#1156] Specify babel-loader version compatible with the node one

24cfd32

[#1156] Reverted package and package-lock

15651eb

[#1156] Installed escape-html and pinned babel-loader version

ea86905

[#1159] Added profile image when accepting an invitation

e02a64a

[#1159] Removed unused code,render avatar div when there is an image

df20204

[#1159] Removed duplicate html code

4dc049b

🎨 [#1132] fixed alignment and add expand_more arrow icon for contacts

7474af7

💄 [#1132] Refactored filter area for Select tag in Contacts

df9f2e7

💄 [#1132] Formatting template

04057f8

💄 [#1132] Solve merge conflict

d5102fc

Merge branch 'develop' into feature/1132-select-element-for-contacts-…

2e08e53

…page

jiromaykin marked this pull request as draft March 5, 2023 14:44

🎨 [#1132] Reverted SCSS to correct develop branch

3e9c0f7

jiromaykin marked this pull request as ready for review March 5, 2023 15:36

jiromaykin requested review from vaszig and Bartvaderkin March 6, 2023 08:49

jiromaykin marked this pull request as draft March 6, 2023 10:11

jiromaykin closed this Mar 6, 2023

jiromaykin deleted the feature/1132-select-element-for-contacts-page branch March 7, 2023 09:32

jiromaykin mentioned this pull request Mar 7, 2023

🎨 [#1132] Add select-caret and filters for contacts #520

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

💄 [#1132] Select-element caret for contacts-page #503

💄 [#1132] Select-element caret for contacts-page #503

jiromaykin commented Feb 27, 2023 •

edited

Loading

codecov-commenter commented Feb 27, 2023 •

edited

Loading

vaszig left a comment •

edited

Loading

jiromaykin commented Mar 2, 2023

vaszig Mar 3, 2023

jiromaykin Mar 3, 2023

vaszig Mar 3, 2023

vaszig commented Mar 3, 2023

jiromaykin commented Mar 6, 2023

Bartvaderkin commented Mar 6, 2023 •

edited

Loading

jiromaykin commented Mar 6, 2023

💄 [#1132] Select-element caret for contacts-page #503

💄 [#1132] Select-element caret for contacts-page #503

Conversation

jiromaykin commented Feb 27, 2023 • edited Loading

codecov-commenter commented Feb 27, 2023 • edited Loading

Codecov Report

vaszig left a comment • edited Loading

Choose a reason for hiding this comment

jiromaykin commented Mar 2, 2023

vaszig Mar 3, 2023

Choose a reason for hiding this comment

jiromaykin Mar 3, 2023

Choose a reason for hiding this comment

vaszig Mar 3, 2023

Choose a reason for hiding this comment

vaszig commented Mar 3, 2023

jiromaykin commented Mar 6, 2023

Bartvaderkin commented Mar 6, 2023 • edited Loading

jiromaykin commented Mar 6, 2023

jiromaykin commented Feb 27, 2023 •

edited

Loading

codecov-commenter commented Feb 27, 2023 •

edited

Loading

vaszig left a comment •

edited

Loading

Bartvaderkin commented Mar 6, 2023 •

edited

Loading