Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#1078] frontend a11y issues #468

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Feb 13, 2023

multiple issues:

  • background of success messages (fix errors where a comment breaks the HSL color codes)
  • area of link too large around home-banner image

@jiromaykin jiromaykin changed the title ♿ : [#1078} frontend a11y issues ♿ : [#1078] frontend a11y issues Feb 13, 2023
@jiromaykin jiromaykin changed the title ♿ : [#1078] frontend a11y issues ♿ [#1078] frontend a11y issues Feb 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #468 (604013e) into develop (9e8c1bd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #468   +/-   ##
========================================
  Coverage    96.46%   96.46%           
========================================
  Files          505      506    +1     
  Lines        18255    18263    +8     
========================================
+ Hits         17609    17617    +8     
  Misses         646      646           
Impacted Files Coverage Δ
src/open_inwoner/accounts/forms.py 97.78% <0.00%> (ø)
...migrations/0033_alter_siteconfiguration_favicon.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin marked this pull request as ready for review February 14, 2023 09:19
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Success message works fine!
  • I still see problems with the logo while trying different size images.

2023-02-14_12-44

  • Maybe we should target another class (ex. the image class) and not the parent one (logo).

2023-02-14_12-44_1

@jiromaykin
Copy link
Contributor Author

  • I still see problems with the logo while trying different size images.

Thank you; i see now i need to completely rework the grid.

@jiromaykin jiromaykin requested a review from vaszig February 16, 2023 09:02
@alextreme alextreme merged commit c477504 into develop Feb 16, 2023
@alextreme alextreme deleted the fix/1078-frontend-a11y-issues branch February 16, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants