-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added very basic Open Forms integration #311
Conversation
That black failure is on the develop branch btw. but didn't want to touch it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As discussed with Joeri as well, this shoud not be merged until it is updated with the newer version of open-forms-client.
- The domain (OPEN_FORMS_DOMAIN) should be added via an environmental variable for now.
{% openforms_sdk_media %} | ||
|
||
{% endblock %} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the side bar {% block sidebar_content %}
can be removed and add only a "back or cancel" button, but this can be done when we improve the layout generally.
2b37ffa
to
f12b3fd
Compare
Updated the lib and this PR. No default uuid in the migration needed anymore. |
f12b3fd
to
bea93e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I thought slugfields had a length of 100? I'll check it out. I specifically used the same field as Open Forms to prevent exactly this problem, sigh :) |
Make sure you configure the environment variable "OPEN_FORMS_DOMAIN" to activate proper CSP headers.
bea93e9
to
c0da313
Compare
Increased length to 100 chars. Note, you need to rollback and migrate again to make this effective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the 0.2.2 newer version and it works fine!
Very basic integration of Open Forms building on top of a detail page to show the form directly how it would show in Open Forms. This works with CSP headers and you can nicely select a form on the product admin page, once you configure Open Forms client in the admin.
Make sure you configure the environment variable "OPEN_FORMS_DOMAIN" to activate proper CSP headers. I didn't see any place to document this environment variable
Improvements can definitely be: