Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/OIDC #279

Merged
merged 20 commits into from
Jul 6, 2022
Merged

Feature/OIDC #279

merged 20 commits into from
Jul 6, 2022

Conversation

JostCrow
Copy link
Contributor

No description provided.

@JostCrow JostCrow requested review from vaszig and annashamray June 27, 2022 13:50
@JostCrow JostCrow marked this pull request as ready for review June 27, 2022 13:50
vaszig
vaszig requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @JostCrow as well, the following should be added-fixed:

  • Add settings-configuration details for the admin page to taiga ticket

  • Check whether we receive the email from the external page or not

@JostCrow JostCrow requested review from vaszig and alextreme June 29, 2022 13:57
alextreme
alextreme approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the integration, the @openinwoner.nl-bits do feel like a bit of a hack so I'm curious if Anna has suggestions on how to do this better.

@JostCrow
Copy link
Contributor Author

It indeed is a bit of a hack. But the problem is that an email address needs to be present. Otherwise only one user can login with OIDC if it stays empty.

annashamray
annashamray reviewed Jun 30, 2022
View reviewed changes
annashamray
annashamray approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except one minor typo it looks very nice.

@JostCrow @annashamray
Update src/open_inwoner/accounts/backends.py
6841cf6 
Co-authored-by: Anna Shamray <47745906+annashamray@users.noreply.github.com>
@alextreme alextreme merged commit 1690be2 into develop Jul 6, 2022
@alextreme alextreme deleted the feature/oidc branch July 6, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@annashamray annashamray annashamray approved these changes

@vaszig vaszig vaszig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JostCrow @alextreme @annashamray @vaszig