Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/action is for field #272

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Feature/action is for field #272

merged 2 commits into from
Jun 15, 2022

Conversation

annashamray
Copy link
Contributor

task - https://taiga.maykinmedia.nl/project/open-inwoner/task/698
and action list improvements:

  • show start_date before end_date and in the same format
  • add defaults for empty values to avoid showing 'None'

@annashamray
Copy link
Contributor Author

annashamray commented Jun 15, 2022

@alextreme I couldn't reproduce the empty dropdown, but anyway I changed the field.queryset for both cases - with and without a plan

Without a plan it should be a disabled dropdown

Copy link
Contributor

@JostCrow JostCrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correct. The only small thing that I found is that when an input/select element is disabled, it does not change the cursor to not-allowed.

@annashamray
Copy link
Contributor Author

I can do it but it will not be consistent with our disabled buttons style. In disabled buttons we display default cursor

@alextreme
Copy link
Member

Okay, this is sufficient for now imho.

@alextreme alextreme merged commit 8b0de6d into develop Jun 15, 2022
@alextreme alextreme deleted the feature/action-is-for-field branch June 15, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants