Feature/actions history #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e4533b to
c694d70
Compare
vaszig
reviewed
Jun 9, 2022
| @@ -28,7 +28,7 @@ def get_change_message(fields=None, form=None): | |||
| form, form.changed_data | |||
| ) | |||
|
|
|||
| return _("Changed {changed_fields}.").format( | |||
| return _("Changed: {changed_fields}.").format( | |||
There was a problem hiding this comment.
I don't know if it's really necessary, but we could add here a different message when the user doesn't make an actual change to any field (like django admin's message).
There was a problem hiding this comment.
Thanks for catching it! I think there is no point in logging form submission without the actual change, so I excluded such cases from logging. Now it should be fixed.
JostCrow
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task - https://taiga.maykinmedia.nl/project/open-inwoner/task/506