-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#528] Feature/improve plan template popup #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a styling issue I'll be a little nitpicking
- The margin between title (plan name) and the body below is bigger in the design
- The first column (preview__title) is too wide and it makes the data in the right column to look more crowded
- The file url ("bestand") should be clickable
- "X" button is missing in the top-right corner
- (nice-to-have) I think the popup in the design is a little wider, and with a lot of action templates the wider popup could look nicer, but I don't insist on this one
- (nice-to-have) I'd like to close modal by clicking outside of it. For now if you click outside you can even select radio button which is not nice. But it can be dealt with in another issue
I'll attach the screenshot with my modal so you can double check that it's displayed as expected
Concerning the comments 1,4 and 6:
|
|
Yes, Jorik agrees with adding the "x" button as well, so I will change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreeing with Anna here, the 'x' isn't necessary the work which is done in this PR is sufficient in my eyes too.
No description provided.