Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#635] Fix/pdc admin error in logging #239

Merged
merged 2 commits into from
May 23, 2022
Merged

[#635] Fix/pdc admin error in logging #239

merged 2 commits into from
May 23, 2022

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 23, 2022

No description provided.

@vaszig vaszig requested review from annashamray and JostCrow May 23, 2022 07:58
@vaszig vaszig mentioned this pull request May 23, 2022
Merged
@alextreme
Copy link
Member

@vaszig please add a regressiontest for this issue

@vaszig vaszig added the wip Work in progress label May 23, 2022
@vaszig vaszig removed the wip Work in progress label May 23, 2022
@vaszig vaszig requested a review from alextreme May 23, 2022 15:08
alextreme
alextreme approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the tests :)

@alextreme alextreme merged commit bed0f4e into develop May 23, 2022
@alextreme alextreme deleted the task-635-logging-error branch May 23, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@annashamray annashamray Awaiting requested review from annashamray

@JostCrow JostCrow Awaiting requested review from JostCrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaszig @alextreme