Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#589] Fix/show map's title on a single line #234

Merged
merged 1 commit into from
May 20, 2022
Merged

[#589] Fix/show map's title on a single line #234

merged 1 commit into from
May 20, 2022

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 19, 2022

No description provided.

@vaszig vaszig requested review from JostCrow and annashamray May 19, 2022 09:25
annashamray
annashamray reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this width, it looks funny
image

I'll add other reviewers to gather more opinions

alextreme
alextreme approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would be best to revisit how the popup is designed and functions (this was also Roxanne's feedback during our weekly, as the map currently has limited user-value) but this has been placed on the backlog. For now this is sufficient in my eyes.

@alextreme alextreme merged commit 821cdf7 into develop May 20, 2022
@alextreme alextreme deleted the task-589-map-title-on-single-line branch May 20, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray left review comments

@alextreme alextreme alextreme approved these changes

@JostCrow JostCrow Awaiting requested review from JostCrow

@svenvandescheur svenvandescheur Awaiting requested review from svenvandescheur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaszig @alextreme @annashamray