Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supported subfolder #232

Merged
merged 2 commits into from
May 24, 2022
Merged

supported subfolder #232

merged 2 commits into from
May 24, 2022

Conversation

JostCrow
Copy link
Contributor

No description provided.

@JostCrow JostCrow requested a review from alextreme May 18, 2022 15:54
alextreme
alextreme approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paar zaken die opgeschoond mogen worden, daarna akkoord om te mergen

annashamray
annashamray requested changes May 20, 2022
View reviewed changes
@JostCrow JostCrow requested a review from annashamray May 23, 2022 14:18
annashamray
annashamray reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there can be problems with displaying existing filer images on staging environment and if we need to make a data migration to change path for these images?
Staging env uses MEDIA_SUBFOLDER to separate media of different domains.

@alextreme
Copy link
Member

@annashamray I'll deal with this on the stagingenvironments manually, worst-case is that we have to have a copy for the time being. But a datamigration is more trouble than it's worth in this stage.

@alextreme alextreme merged commit bf95fc4 into develop May 24, 2022
@alextreme alextreme deleted the feature/filer-subfolder branch May 24, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@annashamray annashamray annashamray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JostCrow @alextreme @annashamray