Feature/invite with digid

[annashamray]

task - https://taiga.maykinmedia.nl/project/open-inwoner/task/472

Creating inactive user along with the contact finally shot us in the foot :)

The old process:

• the user creates a contact
• if there is no registered user with email = contact.email a new inactive user is created
• the invite is sent to this email
• the client uses invite and registers on website, i.e. inactive user becomes active one

The problem with this process:

If we allow registering with Digid, when we will have two users: the one signed up with Digid and inactive one, because the Digid user email is created automatically based on their BSN

Possible solution:

Don't create inactive user when the contact is created and update the contact after the user is registered (with or without Digid)

The new process:

• the user creates a contact
• inactive user IS NOT CREATED
• the invite is sent to the contact email
• the client uses invite and registers on website, the user is created and the contact is updated with this user

[vaszig]

Generally, it looks fine to me. The only thing that feels weird to me is when registering via digid. I have two contacts in the list view. Is it because of the mock version of digid? I had a look at the code that creates the contact and the reverse-contact but I didn't see something wrong.

[annashamray]

@vaszig Thanks for catching it! Two contacts (yours and reverse) were created and they were not deduplicated correctly
I simplified the contact queryset making, it should work now

[alextreme]

Works fine, thanks! Glad you're able to round this up properly.

Feedback from my testing:

1. Having users without name/email will cause problems, created task 💄 [#1493] Improve document-upload style and texts #636 as this is separate
2. I'd like a bit more attention to the user interface when confirming the invitation. The DigiD-only option shouldn't be screen-wide, and the DigiD+username option should make clear that you can register via one or the other. My suggestion would be to put both options next to each other (left vs right).
3. The BSN-in-emailadres situation is a bit odd, I created 💄 [#1494] Fix margins and designs in mobile navigation #637 to rectify this.

Point 2 can be completed within this PR, 1+3 can be done in separate ones.

[alextreme]

I'd like a bit more attention to the user interface when confirming the invitation. The DigiD-only option shouldn't be screen-wide, and the DigiD+username option should make clear that you can register via one or the other. My suggestion would be to put both options next to each other (left vs right).

[annashamray]

@alextreme I placed registration with Digid and with email into two columns next to each other

[vaszig]

The styling seems a bit weird to me because of the big difference concerning the height. I would align the two cards vertically (like we do on the login page), but of course this is my opinion!

[alextreme]

Putting it next to eachother was as requested from my end, lets see during UAT if anyone minds as it is a bit inconsistent.