Feature/csp #228
Merged
Feature/csp #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JostCrow
commented
May 18, 2022
•
- Create ckeditor.js for the admin.
- fix pop-up styling
- fix plan template pop-up
Fix Digid logo
alextreme
requested changes
May 18, 2022
There was a problem hiding this comment.
Volgens mij moet dit nog worden aangepast door de unsafe's uit te schakelen.
Mocht je hier twijfels over hebben dan graag even met Sergei hierover hebben, want ik ken django-csp minder goed dan de nginx-level oplossing die we voor VIPS hebben doorgevoerd dus het kan zijn dat ik de configuratie in openforms verkeerd interpreteer.
alextreme
approved these changes
May 24, 2022
|
This will require manual testing on the testenvironment, this took a couple of tries with VIPS and OpenForms. But happy to merge as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.