Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3049] Fix end-date of plan can precede that of action templates #1630

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

linssen814
Copy link
Contributor

Added validation to PlanForm that checks whether the selected end date of a plan does not precede the would-be end-dates of actions in a selected plan template.

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/3049

image

@linssen814 linssen814 force-pushed the issue/3049-einddatum-samenwerking branch 3 times, most recently from 4e8d189 to 73e5fa9 Compare February 20, 2025 13:24
@linssen814 linssen814 force-pushed the issue/3049-einddatum-samenwerking branch 2 times, most recently from 0c5331b to d870687 Compare February 20, 2025 15:54
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (1d0ccd2) to head (103a868).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1630   +/-   ##
========================================
  Coverage    94.20%   94.20%           
========================================
  Files         1086     1086           
  Lines        40026    40057   +31     
========================================
+ Hits         37705    37736   +31     
  Misses        2321     2321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linssen814 linssen814 force-pushed the issue/3049-einddatum-samenwerking branch from 5ebc43d to 50391c1 Compare February 20, 2025 16:48
@linssen814 linssen814 force-pushed the issue/3049-einddatum-samenwerking branch 3 times, most recently from 1e067db to aacbe71 Compare February 24, 2025 16:00
@linssen814 linssen814 force-pushed the issue/3049-einddatum-samenwerking branch from aacbe71 to 103a868 Compare February 25, 2025 13:29
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - also: when putting sprint PR's in Review, drag them in Taiga out of 'in progress' into the "in review" column,
After the PR is merged with Develop, then you can drag the issue in Taiga to 'Client review'
For loose issues/Userstories this is a bit different (when asking for codereview, first drag it to 'implemented', and after merging drag it to 'Ready for test').
So for sprintPR's inside Userstories there's double the amount of dragging to be done.

@jiromaykin
Copy link
Contributor

@linssen814 👋 Kun je de merge-conflicts oplossen voordat we deze rebasen?
Beter ook: alleen PR's aftakken van opnieuw geupdate Develop branch (elke dag meermaals Git pull) en dan kun je lokaal eerst rebasen/forcepush op Develop en dan lokaal merge-conflicts oplossen, nadat je je laatste verandering hebt gepusht (zonder commit).

@linssen814 linssen814 force-pushed the issue/3049-einddatum-samenwerking branch from 103a868 to fa41409 Compare February 27, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants