-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3049] Fix end-date of plan can precede that of action templates #1630
base: develop
Are you sure you want to change the base?
Conversation
4e8d189
to
73e5fa9
Compare
0c5331b
to
d870687
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1630 +/- ##
========================================
Coverage 94.20% 94.20%
========================================
Files 1086 1086
Lines 40026 40057 +31
========================================
+ Hits 37705 37736 +31
Misses 2321 2321 ☔ View full report in Codecov by Sentry. |
5ebc43d
to
50391c1
Compare
1e067db
to
aacbe71
Compare
aacbe71
to
103a868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - also: when putting sprint PR's in Review, drag them in Taiga out of 'in progress' into the "in review" column,
After the PR is merged with Develop, then you can drag the issue in Taiga to 'Client review'
For loose issues/Userstories this is a bit different (when asking for codereview, first drag it to 'implemented', and after merging drag it to 'Ready for test').
So for sprintPR's inside Userstories there's double the amount of dragging to be done.
@linssen814 👋 Kun je de merge-conflicts oplossen voordat we deze rebasen? |
103a868
to
fa41409
Compare
Added validation to
PlanForm
that checks whether the selected end date of a plan does not precede the would-be end-dates of actions in a selected plan template.Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/3049