Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ruff pep8-naming rule #1616

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Apply ruff pep8-naming rule #1616

merged 2 commits into from
Mar 3, 2025

Conversation

pi-sigma
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (01ffa41) to head (9dfb6d3).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1616   +/-   ##
========================================
  Coverage    94.17%   94.17%           
========================================
  Files         1086     1086           
  Lines        40065    40065           
========================================
  Hits         37732    37732           
  Misses        2333     2333

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review February 12, 2025 10:00
@pi-sigma pi-sigma requested a review from swrichards February 12, 2025 10:01
@pi-sigma pi-sigma force-pushed the ruff/pep8-naming branch 4 times, most recently from 0d51c77 to 142c75f Compare February 19, 2025 13:59
@pi-sigma pi-sigma changed the title Enable ruff pep8-naming rule Apply ruff pep8-naming rule Feb 19, 2025
swrichards
swrichards approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small suggestions

@pi-sigma pi-sigma force-pushed the ruff/pep8-naming branch 2 times, most recently from b8c4e2b to 76151c3 Compare March 3, 2025 13:50
@swrichards swrichards enabled auto-merge (rebase) March 3, 2025 14:19
@pi-sigma pi-sigma force-pushed the ruff/pep8-naming branch 2 times, most recently from 3ed8292 to 0c9a577 Compare March 3, 2025 14:57
@swrichards swrichards merged commit aa306e5 into develop Mar 3, 2025
22 checks passed
@swrichards swrichards deleted the ruff/pep8-naming branch March 3, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pi-sigma @codecov-commenter @swrichards