Fix uWSGI port config for Docker #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker uWSGI config had two issues: - It didn't specfy an address to listen on, so it would only listen on localhost by default - It used UWSGI_PORT to customize the port, which is not a recognized uWSGI option, but because it follows the naming scheme, was evaluated by uWSGI which then failed because of strict mode. This commit changes this to always bind on all addresses, and to use the more conventional $PORT environment variable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1610 +/- ##
========================================
Coverage 94.22% 94.22%
========================================
Files 1080 1080
Lines 39886 39886
========================================
Hits 37582 37582
Misses 2304 2304 ☔ View full report in Codecov by Sentry. |
alextreme
approved these changes
Feb 7, 2025
|
Tagged with v1.27.0-rc2, thanks for the late-night fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker uWSGI config had two issues:
This commit changes this to always bind on all addresses, and to use the more conventional $PORT environment variable.