[#2967] Fix verification email not sent #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1600 +/- ##
========================================
Coverage 94.19% 94.20%
========================================
Files 1080 1080
Lines 39773 39790 +17
========================================
+ Hits 37466 37483 +17
Misses 2307 2307 ☔ View full report in Codecov by Sentry. |
swrichards
requested changes
Feb 5, 2025
- The verification email flow was previously changed to account
for duplicate emails sent during registration or profile edits.
This had the effect that emails were *not* automatically sent
at all when the user changed their email again.
5e3a8c1 to
c10abc9
Compare
swrichards
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verification email flow was previously changed to account for duplicate emails sent during registration or profile edits. This had the effect that emails were not automatically sent at all when the user changed their email again.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2967