Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api mocks for testing #1598

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Remove api mocks for testing #1598

merged 1 commit into from
Feb 4, 2025

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Feb 4, 2025

The api mocks are/were used for testing the old openklant + eSuite API's. They are no longer needed and can be removed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (d51795d) to head (ee11591).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1598   +/-   ##
========================================
  Coverage    94.19%   94.20%           
========================================
  Files         1082     1079    -3     
  Lines        39719    39646   -73     
========================================
- Hits         37412    37347   -65     
+ Misses        2307     2299    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review February 4, 2025 15:41
@pi-sigma pi-sigma requested a review from swrichards February 4, 2025 15:41
@swrichards swrichards merged commit a6d78fa into develop Feb 4, 2025
22 checks passed
@swrichards swrichards deleted the cleanup/apimock branch February 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants