Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eherkenning eenmanszaak flag to more natural SiteConfiguration #1597

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

swrichards
Copy link
Collaborator

This flag didn't really make sense in the OpenZaakConfig, it's site-wide: I've moved it together with the other login related flags in the general SiteConfiguration.

@swrichards swrichards force-pushed the move-eenmanszaak-eherkenning-login-flag branch from 7895f32 to c62326d Compare February 4, 2025 09:28
@swrichards swrichards marked this pull request as ready for review February 4, 2025 09:28
@swrichards swrichards force-pushed the move-eenmanszaak-eherkenning-login-flag branch 2 times, most recently from eb45cea to 79f2ffe Compare February 4, 2025 09:46
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.19%. Comparing base (8c69698) to head (992f90f).

Files with missing lines Patch % Lines
...onfiguration_enable_eherkenning_for_eenmanszaak.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1597      +/-   ##
===========================================
- Coverage    94.19%   94.19%   -0.01%     
===========================================
  Files         1080     1082       +2     
  Lines        39699    39719      +20     
===========================================
+ Hits         37395    37412      +17     
- Misses        2304     2307       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards requested a review from pi-sigma February 4, 2025 11:23
@swrichards swrichards force-pushed the move-eenmanszaak-eherkenning-login-flag branch from 79f2ffe to d15aea5 Compare February 4, 2025 12:05
@swrichards swrichards force-pushed the move-eenmanszaak-eherkenning-login-flag branch 2 times, most recently from b4d29bd to e6f06e5 Compare February 4, 2025 13:15
@swrichards swrichards force-pushed the move-eenmanszaak-eherkenning-login-flag branch from e6f06e5 to 992f90f Compare February 4, 2025 13:19
@swrichards swrichards requested a review from pi-sigma February 4, 2025 13:20
@swrichards swrichards merged commit d51795d into develop Feb 4, 2025
22 checks passed
@swrichards swrichards deleted the move-eenmanszaak-eherkenning-login-flag branch February 4, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants