Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📈 [#2965] Add 'Mijn aanvragen' Siteimprove tracking (Dynamic errors) #1563

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jan 16, 2025

Separate issue for more complex dynamic tracking,
"...Ik wil weten hoeveel mensen een verkeerd bestand uploaden en daardoor een error krijgen. Dit uitgesplitst in een error van een te groot bestand en een error van een verkeerd bestand..."
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2965

+This code also corrects an old bug from 3 years ago "Unresolved variable or type selects" in the Mijn Samenwerkingen dropdown Select-filter.

@jiromaykin jiromaykin marked this pull request as draft January 16, 2025 14:05
@jiromaykin jiromaykin changed the title Feature/2965 sitemprove dynamic cases 📈 [#2965] Add 'Mijn aanvragen' Siteimprove tracking (Dynamic) Jan 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (a6d78fa) to head (6ed3241).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1563   +/-   ##
========================================
  Coverage    94.20%   94.20%           
========================================
  Files         1079     1079           
  Lines        39646    39646           
========================================
  Hits         37347    37347           
  Misses        2299     2299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin changed the title 📈 [#2965] Add 'Mijn aanvragen' Siteimprove tracking (Dynamic) 📈 [#2965] Add 'Mijn aanvragen' Siteimprove tracking (Dynamic errors) Jan 28, 2025
@jiromaykin jiromaykin force-pushed the feature/2965-sitemprove-dynamic-cases branch 5 times, most recently from 25b7d9a to 79c8f7e Compare January 30, 2025 11:16
@jiromaykin jiromaykin added the wip Work in progress label Jan 30, 2025
@jiromaykin jiromaykin requested a review from stefrado February 3, 2025 13:55
@jiromaykin
Copy link
Contributor Author

@stefrado Kun je alvast uittesten of deze eigenlijk wel goed werkt? (dus: files uploaden met fouten als "te groot / verkeerd type/ beide")? En dan files verwijderen/nieuwe uploaden etc. De code staat nog helemaal vol met console.logs die er in de definitieve versie uit moeten + ook de "_sz" mock moet worden uitgecomment zodra deze goed is voor productie.

@jiromaykin jiromaykin force-pushed the feature/2965-sitemprove-dynamic-cases branch 2 times, most recently from 54024fd to 21d448a Compare February 4, 2025 15:51
@jiromaykin jiromaykin removed the wip Work in progress label Feb 4, 2025
@jiromaykin jiromaykin marked this pull request as ready for review February 4, 2025 15:56
@jiromaykin jiromaykin force-pushed the feature/2965-sitemprove-dynamic-cases branch from 21d448a to 6ed3241 Compare February 4, 2025 16:10
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions (mainly for my own understanding).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly unrelated, but: I assume that's a typo in the (pre-existing) filename?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to keep the filename so we can see the delta/changes - but the developer who made this may have set this name to avoid conflicts with other JS files? But prob a typo. I don't know...

@alextreme alextreme merged commit ea4d1ef into develop Feb 6, 2025
22 checks passed
@alextreme alextreme deleted the feature/2965-sitemprove-dynamic-cases branch February 6, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants