-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📈 [#2965] Add 'Mijn aanvragen' Siteimprove tracking (Dynamic errors) #1563
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1563 +/- ##
========================================
Coverage 94.20% 94.20%
========================================
Files 1079 1079
Lines 39646 39646
========================================
Hits 37347 37347
Misses 2299 2299 ☔ View full report in Codecov by Sentry. |
25b7d9a
to
79c8f7e
Compare
@stefrado Kun je alvast uittesten of deze eigenlijk wel goed werkt? (dus: files uploaden met fouten als "te groot / verkeerd type/ beide")? En dan files verwijderen/nieuwe uploaden etc. De code staat nog helemaal vol met console.logs die er in de definitieve versie uit moeten + ook de "_sz" mock moet worden uitgecomment zodra deze goed is voor productie. |
54024fd
to
21d448a
Compare
21d448a
to
6ed3241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few questions (mainly for my own understanding).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly unrelated, but: I assume that's a typo in the (pre-existing) filename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wanted to keep the filename so we can see the delta/changes - but the developer who made this may have set this name to avoid conflicts with other JS files? But prob a typo. I don't know...
Separate issue for more complex dynamic tracking,
"...Ik wil weten hoeveel mensen een verkeerd bestand uploaden en daardoor een error krijgen. Dit uitgesplitst in een error van een te groot bestand en een error van een verkeerd bestand..."
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2965
+This code also corrects an old bug from 3 years ago "Unresolved variable or type selects" in the Mijn Samenwerkingen dropdown Select-filter.