Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eSuite user syncing refactors #1546

Merged
merged 5 commits into from
Jan 13, 2025
Merged

eSuite user syncing refactors #1546

merged 5 commits into from
Jan 13, 2025

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Jan 9, 2025 •
edited
Loading

Some ground-clearing in preparation for a PR to actually sync new user data to eSuite upon user creation.

@swrichards swrichards force-pushed the 2059-sync-user-to-klant-systeem-on-create branch 2 times, most recently from ed85115 to 928216d Compare January 9, 2025 16:43
@swrichards swrichards changed the title Sync users to eSuite upon klant creation eSuite user syncing refactors Jan 9, 2025
@swrichards swrichards requested a review from pi-sigma January 9, 2025 17:05
@swrichards swrichards marked this pull request as ready for review January 9, 2025 17:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.23%. Comparing base (fcb8638) to head (13ace26).

Files with missing lines Patch % Lines
src/open_inwoner/accounts/signals.py 88.23% 2 Missing ⚠️
src/open_inwoner/cms/cases/views/status.py 80.00% 2 Missing ⚠️
src/open_inwoner/openklant/services.py 86.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1546      +/-   ##
===========================================
+ Coverage    94.12%   94.23%   +0.11%     
===========================================
  Files         1067     1068       +1     
  Lines        39338    39348      +10     
===========================================
+ Hits         37026    37080      +54     
+ Misses        2312     2268      -44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi-sigma
pi-sigma approved these changes Jan 10, 2025
View reviewed changes
@alextreme
Copy link
Member

@swrichards can be merged after resolving the conflict

@swrichards swrichards force-pushed the 2059-sync-user-to-klant-systeem-on-create branch from 928216d to 3d38a48 Compare January 13, 2025 09:51
@swrichards swrichards force-pushed the 2059-sync-user-to-klant-systeem-on-create branch from c6e0f9e to 13ace26 Compare January 13, 2025 11:18
@alextreme alextreme merged commit 65b1058 into develop Jan 13, 2025
21 checks passed
@alextreme alextreme deleted the 2059-sync-user-to-klant-systeem-on-create branch January 13, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swrichards @codecov-commenter @alextreme @pi-sigma