Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2808] Use KVK API to check legal status of compay at login #1544

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[#2808] Use KVK API to check legal status of compay at login #1544

merged 1 commit into from
Jan 22, 2025

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Jan 8, 2025

@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch 4 times, most recently from dc8339d to 187870b Compare January 10, 2025 14:44
@pi-sigma pi-sigma changed the title [#2808] Use KVK API to checkout legal status of compay at login [#2808] Use KVK API to check legal status of compay at login Jan 10, 2025
@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch 3 times, most recently from f003155 to 125b3b8 Compare January 10, 2025 16:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.22%. Comparing base (fef8255) to head (dedb970).

Files with missing lines Patch % Lines
src/open_inwoner/accounts/views/auth.py 62.50% 6 Missing ⚠️
src/open_inwoner/kvk/client.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1544      +/-   ##
===========================================
- Coverage    94.23%   94.22%   -0.02%     
===========================================
  Files         1068     1068              
  Lines        39385    39428      +43     
===========================================
+ Hits         37115    37151      +36     
- Misses        2270     2277       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch 2 times, most recently from 2022bde to 3d67a46 Compare January 14, 2025 11:44
@pi-sigma pi-sigma marked this pull request as ready for review January 14, 2025 13:02
@pi-sigma pi-sigma requested a review from swrichards January 14, 2025 13:02
@pi-sigma pi-sigma marked this pull request as draft January 16, 2025 12:00
@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch from 3d67a46 to dedb970 Compare January 16, 2025 12:01
@pi-sigma pi-sigma marked this pull request as ready for review January 16, 2025 13:02
@pi-sigma pi-sigma requested a review from swrichards January 16, 2025 13:02
swrichards
swrichards approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, holding off on merge until after v1.26.0.

@alextreme alextreme merged commit 7a79e99 into develop Jan 22, 2025
21 checks passed
@alextreme alextreme deleted the issue/2808-eherkenning-login-error-message branch January 22, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @swrichards @alextreme