Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for use of klanten services #1494

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Improve error handling for use of klanten services #1494

merged 1 commit into from
Nov 13, 2024

Conversation

pi-sigma
Copy link
Contributor

No description provided.

@pi-sigma pi-sigma force-pushed the issue/openklant2-integration branch from fd514bf to 3162927 Compare November 13, 2024 10:44
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.

Project coverage is 94.29%. Comparing base (5e660ba) to head (ddc820e).

Files with missing lines Patch % Lines
src/open_inwoner/accounts/views/contactmoments.py 68.42% 6 Missing ⚠️
src/open_inwoner/accounts/signals.py 68.75% 5 Missing ⚠️
src/open_inwoner/openklant/services.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1494   +/-   ##
========================================
  Coverage    94.29%   94.29%           
========================================
  Files         1066     1066           
  Lines        40141    40157   +16     
========================================
+ Hits         37849    37866   +17     
+ Misses        2292     2291    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the issue/openklant2-integration branch from 3162927 to 57dfbd7 Compare November 13, 2024 11:05
@pi-sigma pi-sigma marked this pull request as ready for review November 13, 2024 11:08
@pi-sigma pi-sigma requested a review from swrichards November 13, 2024 11:08
swrichards
swrichards requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, just small things.

@pi-sigma pi-sigma force-pushed the issue/openklant2-integration branch from 57dfbd7 to a10d05d Compare November 13, 2024 12:01
swrichards
swrichards requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nitpick

@pi-sigma pi-sigma force-pushed the issue/openklant2-integration branch from a10d05d to ddc820e Compare November 13, 2024 13:08
@swrichards swrichards self-requested a review November 13, 2024 13:19
@swrichards swrichards requested a review from alextreme November 13, 2024 14:01
@alextreme alextreme merged commit 9d468e1 into develop Nov 13, 2024
20 checks passed
@alextreme alextreme deleted the issue/openklant2-integration branch November 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

@alextreme alextreme Awaiting requested review from alextreme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @swrichards @alextreme