Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark incorrectly untagged elasticsearch tests #1477

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Oct 30, 2024

These always get in the way of my 100% pass rate when running python src/manage.py test open_inwoner --exclude-tag=e2e --exclude-tag=elastic (they pass on the CI main run, which runs with the same flags, because we always have an elasticsearch instance running).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (c173dcb) to head (e91dce3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1477   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files         1065     1065           
  Lines        39734    39737    +3     
========================================
+ Hits         37588    37591    +3     
  Misses        2146     2146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards marked this pull request as ready for review October 30, 2024 15:27
@swrichards swrichards requested a review from pi-sigma October 30, 2024 15:29
@swrichards swrichards requested a review from alextreme October 30, 2024 16:55
@alextreme alextreme merged commit 5e2afe4 into develop Oct 30, 2024
20 checks passed
@alextreme alextreme deleted the chore/tag-untagged-es-tests branch October 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants