Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2840] Refactor contactmomenten list and detail to use a protocol for data fetching #1473

Merged
merged 3 commits into from
Nov 1, 2024
Merged

[#2840] Refactor contactmomenten list and detail to use a protocol for data fetching #1473

merged 3 commits into from
Nov 1, 2024

Conversation

swrichards
Copy link
Collaborator

Taiga 2840

This is in preparation for adding OpenKlant2 support.

@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch 2 times, most recently from 2b95ac6 to 1797166 Compare October 28, 2024 16:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.33%. Comparing base (5e2afe4) to head (9775d03).

Files with missing lines Patch % Lines
src/open_inwoner/accounts/views/contactmoments.py 87.50% 4 Missing ⚠️
src/open_inwoner/openklant/services.py 96.25% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1473      +/-   ##
===========================================
+ Coverage    94.31%   94.33%   +0.02%     
===========================================
  Files         1065     1066       +1     
  Lines        40001    40100      +99     
===========================================
+ Hits         37726    37830     +104     
+ Misses        2275     2270       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch 5 times, most recently from 060eeb8 to c43a964 Compare October 30, 2024 10:06
@swrichards swrichards marked this pull request as ready for review October 30, 2024 10:07
@swrichards swrichards requested a review from pi-sigma October 30, 2024 10:07
@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch from c43a964 to 426dd23 Compare October 30, 2024 11:18
pi-sigma
pi-sigma requested changes Oct 30, 2024
View reviewed changes
@pi-sigma pi-sigma mentioned this pull request Oct 30, 2024
Merged
@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch from 426dd23 to 4dc5035 Compare October 30, 2024 11:55
@swrichards swrichards requested a review from pi-sigma October 30, 2024 12:00
@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch 3 times, most recently from e443141 to b3c72a2 Compare October 30, 2024 13:20
@swrichards swrichards marked this pull request as draft October 30, 2024 13:42
@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch from b3c72a2 to 7cf13c7 Compare October 30, 2024 13:48
@swrichards swrichards marked this pull request as ready for review October 30, 2024 14:12
@swrichards swrichards marked this pull request as draft October 30, 2024 21:50
@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch 4 times, most recently from f056ffa to 9be2346 Compare October 31, 2024 10:29
@swrichards swrichards marked this pull request as ready for review October 31, 2024 10:35
@swrichards swrichards requested a review from pi-sigma October 31, 2024 10:35
@swrichards swrichards force-pushed the tasks/2840-contactmoment-view-protocols branch from 9be2346 to 9775d03 Compare October 31, 2024 15:40
@swrichards swrichards requested a review from pi-sigma October 31, 2024 15:50
@alextreme alextreme merged commit b29ca59 into develop Nov 1, 2024
20 checks passed
@alextreme alextreme deleted the tasks/2840-contactmoment-view-protocols branch November 1, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swrichards @codecov-commenter @pi-sigma @alextreme