Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2372] Fix dyslexia data-attributes for toggling accessible label #1464

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jiromaykin
Copy link
Contributor

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2372

Chose to not remove the attributes, but correctly toggle them instead.

@jiromaykin jiromaykin changed the title [#2372] Fixed dyslexia data-attributes for toggling accessible label ♿ [#2372] Fix dyslexia data-attributes for toggling accessible label Oct 24, 2024
@jiromaykin jiromaykin marked this pull request as ready for review October 24, 2024 09:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (5391b5f) to head (aaf7edf).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1464   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files         1063     1063           
  Lines        39681    39681           
========================================
  Hits         37537    37537           
  Misses        2144     2144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin requested a review from pi-sigma October 24, 2024 09:28
@alextreme alextreme merged commit 91da9fe into develop Oct 28, 2024
20 checks passed
@alextreme alextreme deleted the issue/2372-A11y-toggle-dyslexia-attribute branch October 28, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants