[#2811] Exclude empty email/phone number from being sent with contactform #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0e103c to
19d556c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1455 +/- ##
===========================================
- Coverage 94.59% 94.56% -0.03%
===========================================
Files 1065 1065
Lines 39728 39691 -37
===========================================
- Hits 37580 37535 -45
- Misses 2148 2156 +8 ☔ View full report in Codecov by Sentry. |
swrichards
requested changes
Oct 23, 2024
Comment on lines
+108
to
+130
| user_email = ( | ||
| api_user_email # pulled from klanten api | ||
| or getattr(self.request.user, "email", None) | ||
| or form.cleaned_data["email"] | ||
| ) |
There was a problem hiding this comment.
I actually think having the form email take precedence makes more sense (it is the most up-to-date, the user literally just provided it), but maybe we should discuss separately with @alextreme / Bobby as this is a change of behavior and not what the PR is about.
51d1782 to
6153caf
Compare
6153caf to
c153c30
Compare
- don't attempt to create klant for anon user (this is not possible
in the eSuite; relevant code is probably left-over from earlier
implementation)
- simplify logic by breaking out fetching of klant + creation of
contactmoment into helper functions
c153c30 to
4a799f8
Compare
swrichards
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2811