Disable playwright browser cache in CI #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the Playwright docs, caching browsers is not recommended, both because downloading the binary is not much slower, but also because system dependencies are required, and these cannot be cached. Even worse, the system dependencies can become stale as the CI images get upgraded. This seems to have happened recently, with persistent "It looks like you are using Playwright Sync API inside the asyncio loop." errors sporadically appearing (in this case, for webkit only) and this being fixed, without further code changes, by disabling the browser cache.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1450 +/- ##
========================================
Coverage 94.59% 94.59%
========================================
Files 1071 1071
Lines 39704 39704
========================================
Hits 37557 37557
Misses 2147 2147 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Playwright docs, caching browsers is not recommended, both because downloading the binary is not much slower, but also because system dependencies are required, and these cannot be cached. Even worse, the system dependencies can become stale as the CI images get upgraded. This seems to have happened recently, with persistent "It looks like you are using Playwright Sync API inside the asyncio loop." errors sporadically appearing (in this case, for webkit only) and this being fixed, without further code changes, by disabling the browser cache.