[#2618] Replace digid_eherkenning_oidc_generics with library #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade digid-eherkenning to a version with OIDC support. This requires a newer version of mozilla-django-oidc-db too.
0cced56 to
6329b3a
Compare
- The tables for our vendored copy of the digid_eherkenning library
need to be removed manually before the migrations of the new library
can be run in order to avoid conflicts due to duplicate tables (the
db tables from the library use the same app label as our legacy package)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1448 +/- ##
===========================================
- Coverage 94.58% 94.58% -0.01%
===========================================
Files 1069 1061 -8
Lines 39623 39627 +4
===========================================
+ Hits 37478 37481 +3
- Misses 2145 2146 +1 ☔ View full report in Codecov by Sentry. |
6329b3a to
637151c
Compare
swrichards
approved these changes
Oct 17, 2024
|
We need to make very clear that OIDC needs to be reconfigured with this change but glad that we were able to get this done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion we decided to replace our code with the library without copying the configuration; this has to be done manually by the client.
Cherry-picked/adapted from #1297
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/us/2617?milestone=511