Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Venray #121] Support sorting the statusses on date set (Rx.mission, Open Zaak) #1446

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[Venray #121] Support sorting the statusses on date set (Rx.mission, Open Zaak) #1446

merged 1 commit into from
Oct 22, 2024

Conversation

alextreme
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (0862012) to head (ab042b5).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1446   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files         1062     1063    +1     
  Lines        39651    39672   +21     
========================================
+ Hits         37507    37528   +21     
  Misses        2144     2144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi-sigma
pi-sigma requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needed

swrichards
swrichards requested changes Oct 15, 2024
View reviewed changes
@alextreme
Copy link
Member Author

@pi-sigma PR has been confirmed to work for the 2 Rx.mission instances with the fix from Sidney using tag venray-121-pr-1446-v2, please resolve the remaining issues so we can include it in a regular release

@alextreme alextreme requested a review from pi-sigma October 17, 2024 09:44
@pi-sigma pi-sigma marked this pull request as draft October 17, 2024 15:07
@pi-sigma pi-sigma marked this pull request as ready for review October 18, 2024 08:09
@pi-sigma pi-sigma requested a review from swrichards October 18, 2024 08:09
pi-sigma
pi-sigma approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swrichards should take another look as well

@alextreme alextreme force-pushed the issue/venray-121 branch 2 times, most recently from dd3fe18 to 7752d2a Compare October 21, 2024 20:07
@alextreme alextreme requested a review from pi-sigma October 21, 2024 20:23
@alextreme
Copy link
Member Author

Sorry Paul, made a bit of a mess with fixing the migrations on this one

@pi-sigma pi-sigma force-pushed the issue/venray-121 branch 2 times, most recently from c6f3f90 to 8b00847 Compare October 22, 2024 08:31
@alextreme
Copy link
Member Author

thanks!

@alextreme alextreme merged commit 111e94e into develop Oct 22, 2024
20 checks passed
@alextreme alextreme deleted the issue/venray-121 branch October 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alextreme @codecov-commenter @swrichards @pi-sigma