Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2789] Model "Mijn Vragen" in OpenKlant2 as klantcontacten #1423

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Oct 3, 2024

@swrichards swrichards requested a review from pi-sigma October 3, 2024 13:33
@swrichards swrichards force-pushed the tasks/2789-implement-q-and-a-model-openklant2 branch from aa8cec5 to 34a5d80 Compare October 3, 2024 13:39
@swrichards swrichards force-pushed the tasks/2789-implement-q-and-a-model-openklant2 branch from 34a5d80 to c3799c1 Compare October 3, 2024 13:59
@swrichards swrichards marked this pull request as ready for review October 3, 2024 14:02
@swrichards swrichards force-pushed the tasks/2789-implement-q-and-a-model-openklant2 branch 2 times, most recently from c109de8 to e5e765d Compare October 3, 2024 14:15
@swrichards swrichards force-pushed the tasks/2789-implement-q-and-a-model-openklant2 branch from e5e765d to b860602 Compare October 3, 2024 14:20
@swrichards swrichards requested a review from pi-sigma October 3, 2024 14:23
@swrichards swrichards requested a review from alextreme October 3, 2024 14:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.87500% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (cdaab0d) to head (b860602).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/services.py 95.29% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1423      +/-   ##
===========================================
+ Coverage    94.52%   94.59%   +0.07%     
===========================================
  Files         1069     1069              
  Lines        39487    39612     +125     
===========================================
+ Hits         37325    37472     +147     
+ Misses        2162     2140      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"hadKlantcontact": {"uuid": answer_klantcontact["uuid"]},
"initiator": True,
"wasPartij": {"uuid": partij["uuid"]},
"organisatienaam": "Open Inwoner Platform",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graag op self zetten als constant zodat we dit later configureerbaar maken

taak = self.client.interne_taak.create(
data={
"aanleidinggevendKlantcontact": {"uuid": klantcontact["uuid"]},
"toelichting": "Beantwoorden vraag",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graag op self zetten als constant zodat we dit later configureerbaar maken

@alextreme alextreme merged commit 96c7bf1 into develop Oct 4, 2024
20 checks passed
@alextreme alextreme deleted the tasks/2789-implement-q-and-a-model-openklant2 branch October 4, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants