[#2795] More fine-grained error handling in concurrent case fetching #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1421 +/- ##
===========================================
- Coverage 94.85% 94.84% -0.02%
===========================================
Files 1049 1049
Lines 38837 38855 +18
===========================================
+ Hits 36840 36853 +13
- Misses 1997 2002 +5 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Oct 3, 2024
These changes are necessary because we do not want a failure to resolve a single case to abort the thread for the whole API group. If one case fails, we should still try and return the cases that properly resolve.
31ca881 to
a124447
Compare
|
@pi-sigma thanks for the improvement: I've also raised the timeout limits a bit (I was hitting them locally). |
pi-sigma
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga 2795.
These changes are necessary because we do not want a failure to resolve a single case to abort the thread for the whole API group. If one case fails, we should still try and return the cases that properly resolve.