Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2771] Add support for fetching open submissions with KVK #1411

Merged
merged 3 commits into from
Sep 30, 2024
Merged

[#2771] Add support for fetching open submissions with KVK #1411

merged 3 commits into from
Sep 30, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma
Copy link
Contributor Author

Our caching mechanism:

open-inwoner/src/open_inwoner/utils/decorators.py

Line 59 in 08e3b2a

def cache(

does not work properly when applied to the methods of the FormClient, it always reports a cache hit independently of the cache key. I left it out for the time being, hence the method calls are not cached. Further investigation needed, caching should be added once this is fixed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.79279% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.88%. Comparing base (f0aedc1) to head (4cdf70e).

Files with missing lines Patch % Lines
src/open_inwoner/openzaak/clients.py 80.00% 5 Missing ⚠️
src/open_inwoner/cms/cases/views/cases.py 88.46% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1411      +/-   ##
===========================================
- Coverage    94.89%   94.88%   -0.01%     
===========================================
  Files         1046     1045       -1     
  Lines        38612    38682      +70     
===========================================
+ Hits         36640    36704      +64     
- Misses        1972     1978       +6
Flag Coverage Δ
94.88% <92.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review September 26, 2024 10:29
@pi-sigma pi-sigma marked this pull request as draft September 26, 2024 10:31
@pi-sigma pi-sigma marked this pull request as ready for review September 26, 2024 11:52
@pi-sigma pi-sigma requested a review from swrichards September 26, 2024 11:52
swrichards
swrichards requested changes Sep 26, 2024
View reviewed changes
@pi-sigma pi-sigma force-pushed the task/2771-open-submissions branch from 07846f7 to 1d80632 Compare September 26, 2024 14:30
swrichards
swrichards requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just unsure about the reason for the UUID test change (see comment).

@pi-sigma pi-sigma force-pushed the task/2771-open-submissions branch 3 times, most recently from 91b6ce8 to 5119cae Compare September 27, 2024 07:54
@pi-sigma pi-sigma requested a review from swrichards September 27, 2024 09:57
swrichards
swrichards approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick, otherwise LGTM.

@pi-sigma
[#2771] Fetch open submissions for multiple ZGW api groups
949b3b3
@pi-sigma
[#2771] Refactor ZGW fetch parameter utility
329532b 
    - The parameter `kvk_or_rsin` returned by the utility is split
      into two parameters; it is now up to the caller to distinguish
      between them. The utility becomes more flexible, which is needed
      for fetching `openstaande inzendingen` with kvk (fetch with rsin
      is not (yet) supported).
@pi-sigma
[#2771] Support fetching openstaande inzendingen with KVK
4cdf70e
@pi-sigma pi-sigma force-pushed the task/2771-open-submissions branch from 5119cae to 4cdf70e Compare September 30, 2024 08:52
@alextreme alextreme merged commit abe460f into develop Sep 30, 2024
20 checks passed
@alextreme alextreme deleted the task/2771-open-submissions branch September 30, 2024 09:19
swrichards pushed a commit that referenced this pull request Sep 30, 2024
@alextreme @swrichards
Merge pull request #1411 from maykinmedia/task/2771-open-submissions
8bd137d 
[#2771] Add support for fetching open submissions with KVK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

@alextreme alextreme Awaiting requested review from alextreme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @swrichards @alextreme