Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2779] Only filter case list by open and closed status #1410

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[#2779] Only filter case list by open and closed status #1410

merged 1 commit into from
Sep 26, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Sep 26, 2024 •
edited
Loading

@swrichards swrichards force-pushed the tasks/2779-filter-cases-by-open-closed branch 4 times, most recently from cf20763 to 0adc437 Compare September 26, 2024 10:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.89%. Comparing base (9089716) to head (0699bc6).

Files with missing lines Patch % Lines
src/open_inwoner/cms/cases/views/cases.py 92.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1410   +/-   ##
========================================
  Coverage    94.88%   94.89%           
========================================
  Files         1046     1046           
  Lines        38605    38610    +5     
========================================
+ Hits         36631    36638    +7     
+ Misses        1974     1972    -2
Flag Coverage Δ
94.89% <96.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the tasks/2779-filter-cases-by-open-closed branch from 0adc437 to 0c388bc Compare September 26, 2024 11:29
@swrichards swrichards marked this pull request as ready for review September 26, 2024 11:52
@swrichards swrichards requested a review from pi-sigma September 26, 2024 11:52
@swrichards swrichards force-pushed the tasks/2779-filter-cases-by-open-closed branch 3 times, most recently from 560a790 to c8e2477 Compare September 26, 2024 12:18
pi-sigma
pi-sigma reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll take another look when the submit button is back

@swrichards swrichards force-pushed the tasks/2779-filter-cases-by-open-closed branch from 00e36ed to 873cd7d Compare September 26, 2024 12:46
@swrichards
Copy link
Collaborator Author

swrichards commented Sep 26, 2024 •
edited
Loading

Looks good, I'll take another look when the submit button is back

Cherry-picked @jiromaykin 's commit -- let's make sure #1412 is merged before this which is now merged, so this is good to go.

@pi-sigma pi-sigma self-requested a review September 26, 2024 14:35
@swrichards swrichards force-pushed the tasks/2779-filter-cases-by-open-closed branch from 4da2cfc to 0699bc6 Compare September 26, 2024 15:03
@swrichards swrichards merged commit 2835a28 into develop Sep 26, 2024
20 checks passed
@swrichards swrichards deleted the tasks/2779-filter-cases-by-open-closed branch September 26, 2024 15:31
swrichards added a commit that referenced this pull request Sep 30, 2024
@swrichards
Merge pull request #1410 from maykinmedia/tasks/2779-filter-cases-by-…
051d4b1 
…open-closed

[#2779] Only filter case list by open and closed status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swrichards @codecov-commenter @alextreme @pi-sigma