Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2737] Sync user personal data with OpenKlant2 #1396

Merged
merged 3 commits into from
Sep 17, 2024
Merged

[#2737] Sync user personal data with OpenKlant2 #1396

merged 3 commits into from
Sep 17, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Sep 12, 2024 •
edited
Loading

@swrichards swrichards force-pushed the tasks/2737-openklant-personal-data-service branch from be537c0 to 19f49ff Compare September 12, 2024 12:31
@swrichards swrichards mentioned this pull request Sep 12, 2024
Merged
@swrichards swrichards force-pushed the tasks/2737-openklant-personal-data-service branch 3 times, most recently from 2c9561e to 95065ed Compare September 12, 2024 17:07
@swrichards swrichards requested a review from pi-sigma September 13, 2024 07:51
pi-sigma
pi-sigma requested changes Sep 13, 2024
View reviewed changes
@swrichards swrichards force-pushed the tasks/2737-openklant-personal-data-service branch from 95065ed to 5b4a0e5 Compare September 16, 2024 12:58
@swrichards swrichards force-pushed the tasks/2737-openklant-personal-data-service branch from 5b4a0e5 to 06ed713 Compare September 16, 2024 13:19
@swrichards swrichards marked this pull request as ready for review September 16, 2024 13:19
@swrichards swrichards requested a review from pi-sigma September 16, 2024 13:25
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.86792% with 13 lines in your changes missing coverage. Please review.

Project coverage is 94.88%. Comparing base (7f55115) to head (78e758a).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/services.py 88.88% 12 Missing ⚠️
src/open_inwoner/openklant/wrap.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1396      +/-   ##
===========================================
- Coverage    94.94%   94.88%   -0.06%     
===========================================
  Files         1043     1046       +3     
  Lines        38290    38604     +314     
===========================================
+ Hits         36353    36630     +277     
- Misses        1937     1974      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi-sigma
pi-sigma approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question, but we can go ahead

@swrichards swrichards force-pushed the tasks/2737-openklant-personal-data-service branch from 06ed713 to 78e758a Compare September 17, 2024 07:55
@swrichards swrichards requested a review from pi-sigma September 17, 2024 07:56
@alextreme alextreme merged commit f06df1b into develop Sep 17, 2024
22 checks passed
@alextreme alextreme deleted the tasks/2737-openklant-personal-data-service branch September 17, 2024 12:14
alextreme
alextreme reviewed Sep 17, 2024
View reviewed changes
src/open_inwoner/openklant/services.py

if (count := resp["count"]) > 0:
if count > 1:
# TODO: Is this a use-case? The API seems to allow this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a valid issue for OK, good that you already raised it: maykinmedia/open-klant#241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme left review comments

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swrichards @codecov-commenter @alextreme @pi-sigma