[#2720] Fix email field prefill in NecessaryFieldsUserView #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1387 +/- ##
===========================================
- Coverage 95.24% 95.24% -0.01%
===========================================
Files 1007 1007
Lines 37347 37339 -8
===========================================
- Hits 35572 35564 -8
Misses 1775 1775 ☔ View full report in Codecov by Sentry. |
7fa270c to
03ff00e
Compare
- Temporary emails created for users who register with bsn,
kvk, or via oidc must be prevented from prefilling the email
field in the `NecessaryUserForm`; the logic for checking this
is simplified by using the `has_usable_email` property
03ff00e to
c071b16
Compare
swrichards
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary emails created for users who register with kvk, or via oidc must be prevented from prefilling the email field in the
NecessaryUserForm; the logic for checking this is simplified by using thehas_usable_emailproperty.Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2720