[#2707] Fix display of notification preferences in profile #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1374 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 1005 1005
Lines 37185 37203 +18
========================================
+ Hits 35404 35423 +19
+ Misses 1781 1780 -1 ☔ View full report in Codecov by Sentry. |
swrichards
approved these changes
Aug 28, 2024
src/open_inwoner/accounts/models.py
Outdated
Comment on lines
396
to
406
| if ( | ||
| config.notifications_messages_enabled | ||
| and self.messages_notifications | ||
| and inbox_page_is_published() | ||
| ): | ||
| enabled.append(_("messages")) | ||
| if self.plans_notifications and collaborate_page_is_published(): | ||
| if ( | ||
| config.notifications_plans_enabled | ||
| and self.plans_notifications | ||
| and collaborate_page_is_published() | ||
| ): |
There was a problem hiding this comment.
Nitpick, but we can express the grouped nature with:
if config.notifications_messages_enabled:
if self.messages_notifications and inbox_page_is_published():
enabled.append(_("messages"))
if self.plans_notifications and collaborate_page_is_published():
enabled.append(_("plans"))There was a problem hiding this comment.
Good idea to make the hierarchy between the options explicit. I'll adopt it.
- The notification section in the profile did not reflect
the admin's choice to enable/disable the relevant notifications.
If the admin disabled notifications about "Samenwerken", they
would still be incorrectly listed.
11d0480 to
0bd87ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification section in the profile did not the admin's choice to enable/disable the relevant notifications. If the admin disabled notifications about "Samenwerken", they would still be listed.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2707