Fix missing mock DigiD/eHerkenning backends in dev #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7abe9d to
7d5e46e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1371 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 1005 1005
Lines 37185 37185
========================================
Hits 35404 35404
Misses 1781 1781 ☔ View full report in Codecov by Sentry. |
We were too eager in 65304e2 in removing all the dev backends, in an attempt to avoid divergence between the base and dev authentication backends. Unfortunately, we mistakenly also removed references to the mock backends, which broke local development which suddenly required production settings for DigiD and eHerkenning. This commit makes more explicit that all we want to do on dev is replace these backends whilst keeping the other settings the same.
7d5e46e to
9a41ede
Compare
pi-sigma
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were too eager in 65304e2 in removing all the dev backends, in an attempt to avoid divergence between the base and dev authentication backends. Unfortunately, we mistakenly also removed references to the mock backends, which broke local development which suddenly required production settings for DigiD and eHerkenning.
This commit makes more explicit that all we want to do on dev is replace these backends whilst keeping the other settings the same.