Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2700] Support multiple ZGW backends for zaak notifications #1370

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Aug 23, 2024

  • Support multiple ZGW backends for status notifications
  • Support multiple ZGW backends for document notifications

Support for retrieving zaak notifications from different notification APIs is out of scope for this ticket

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2700

@pi-sigma pi-sigma force-pushed the task/2700-zaak-notifications-backends branch 3 times, most recently from e920faf to 2aa99a1 Compare August 26, 2024 13:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.23%. Comparing base (24881d7) to head (a2d28f5).
Report is 9 commits behind head on develop.

Files Patch % Lines
...n_inwoner/openzaak/tests/test_notification_data.py 90.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1370      +/-   ##
===========================================
+ Coverage    95.21%   95.23%   +0.02%     
===========================================
  Files         1004     1005       +1     
  Lines        37189    37249      +60     
===========================================
+ Hits         35408    35473      +65     
+ Misses        1781     1776       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review August 26, 2024 14:01
@pi-sigma pi-sigma requested a review from swrichards August 26, 2024 14:01
@pi-sigma pi-sigma marked this pull request as draft August 27, 2024 06:48
@pi-sigma pi-sigma force-pushed the task/2700-zaak-notifications-backends branch from 2aa99a1 to a2d28f5 Compare August 27, 2024 07:35
@pi-sigma pi-sigma marked this pull request as ready for review August 27, 2024 08:31
@pi-sigma pi-sigma requested a review from swrichards August 27, 2024 08:31
@alextreme alextreme merged commit 6dbabce into develop Aug 30, 2024
18 checks passed
@alextreme alextreme deleted the task/2700-zaak-notifications-backends branch August 30, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants