Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanatory note to the ZGW file import admin page #1367

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Aug 21, 2024

This should eventually be better explained in the documentation, but for now it's good to have a temporary notice to guide the user.

Screenshot from 2024-08-22 09-10-46

@swrichards swrichards requested a review from alextreme August 21, 2024 15:41
@swrichards swrichards force-pushed the add-catalogus-config-import-help branch from ce3a524 to 51b1a4b Compare August 21, 2024 16:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (18a524e) to head (a8841dc).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1367      +/-   ##
===========================================
+ Coverage    95.19%   95.20%   +0.01%     
===========================================
  Files         1003     1004       +1     
  Lines        37103    37173      +70     
===========================================
+ Hits         35321    35392      +71     
+ Misses        1782     1781       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the add-catalogus-config-import-help branch from 51b1a4b to e87d376 Compare August 22, 2024 07:04
@swrichards swrichards requested review from jiromaykin and removed request for alextreme August 22, 2024 07:11
@swrichards swrichards marked this pull request as ready for review August 22, 2024 07:11
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier en daar wat foutjes, die eigenlijk niets te maken met de codeverandering. Verder heb ik maar 1 suggestie voor een iets minder wollige tekst.

@swrichards swrichards force-pushed the add-catalogus-config-import-help branch from e87d376 to a8841dc Compare August 22, 2024 08:17
@swrichards swrichards requested a review from jiromaykin August 22, 2024 08:18
@swrichards swrichards requested a review from alextreme August 22, 2024 09:06
@alextreme
Copy link
Member

Looks good!

@alextreme alextreme merged commit d8d72d3 into develop Aug 22, 2024
18 checks passed
@alextreme alextreme deleted the add-catalogus-config-import-help branch August 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants