[#2688] Improve template for user notifications #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c7369e to
45c1e93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1360 +/- ##
==========================================
Coverage ? 95.18%
==========================================
Files ? 1003
Lines ? 37047
Branches ? 0
==========================================
Hits ? 35265
Misses ? 1782
Partials ? 0 ☔ View full report in Codecov by Sentry. |
swrichards
requested changes
Aug 21, 2024
45c1e93 to
5d7c8f1
Compare
- make presence of heading ("choose notifications") dependant on
whether any notifications have been enabled by staff users
5d7c8f1 to
b2b5975
Compare
swrichards
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes the presence of the heading ("choose notifications") contingent on whether any notifications have been enabled by staff users
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2688