Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2689+2690] Improve help texts for notification settings #1359

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Aug 20, 2024

The notification settings in the general site configuration are confusing, mainly because the relationship between enabling these options and the corresponding choices for the user is not obvious. For example, the help text for for notifications about expiring actions suggests that the user will be able to enable/disable these notifications in their profile (or when registering) directly, when in fact the user's choice is logically determined by their choice of notifications about plans).

The PR cleans this up by improving the help texts and rearranging the settings (both in the code and how they appear in the admin and in user-facing templates).

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2689, https://taiga.maykinmedia.nl/project/open-inwoner/issue/2690

@pi-sigma pi-sigma force-pushed the issue/2689-notification-settings branch 2 times, most recently from 5643244 to 46ed83b Compare August 20, 2024 09:15
@pi-sigma pi-sigma changed the title [#2689] Improve help texts for notification settings [#2689+2690] Improve help texts for notification settings Aug 20, 2024
@pi-sigma pi-sigma force-pushed the issue/2689-notification-settings branch from 46ed83b to be68a61 Compare August 20, 2024 09:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (a430792) to head (be68a61).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1359   +/-   ##
========================================
  Coverage    95.19%   95.19%           
========================================
  Files         1002     1003    +1     
  Lines        37029    37033    +4     
========================================
+ Hits         35248    35252    +4     
  Misses        1781     1781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review August 20, 2024 09:45
@pi-sigma pi-sigma requested a review from swrichards August 20, 2024 09:46
@swrichards swrichards requested a review from alextreme August 20, 2024 10:02
@alextreme alextreme merged commit 1dd16ad into develop Aug 20, 2024
18 checks passed
@alextreme alextreme deleted the issue/2689-notification-settings branch August 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants