-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 [#2685] Add snailmail/digital notifications design #1357
💄 [#2685] Add snailmail/digital notifications design #1357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1357 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 1005 1005
Lines 37185 37189 +4
========================================
+ Hits 35404 35408 +4
Misses 1781 1781 ☔ View full report in Codecov by Sentry. |
fa03aab
to
fcef131
Compare
@@ -12,7 +12,7 @@ def icon(icon, **kwargs): | |||
Fontawesome Brands: https://fontawesome.com/v5.15/icons?d=gallery&p=2&s=brands | |||
|
|||
Usage: | |||
{% icon "arrow-forward" %} | |||
{% icon "arrow-forward" outlined=True %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just documentation, but this way it reminds other developers to not forget we use the outlined (not filled) versions.
2e9c24b
to
5926532
Compare
9ae19e6
to
319ec9b
Compare
Oh yeah: @pi-sigma @swrichards If we don't need the template tag, I could remove it but... this way I think it's clearer we can re-use this + I did not style the vertical |
src/open_inwoner/accounts/templates/accounts/registration_necessary.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the current setting is properly synced upon loading the profile:
Screencast.from.2024-08-27.16-58-14.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are (potentially) several issues:
- the "Communicatiekanaal" in the profile is at least misleading because it doesn't reflect the user's choice when they sign up or change their profile. However, I'm not sure if this should be addressed or how, since the choice only concerns notifications about zaak notificaties where action is required (there is no post for notifications about actions or messages)
- it would be nice if the radio was pre-selected according to the user's choice. So if I sign up with "Digitaal en per brief", the corresponding radio choice is pre-selected when I edit my profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, reality is not represented nicely for the "email" thing (also: not all municipalities will be using this), so I've created a new issue which I can pick up after completing this PR properly (preferring to keep development on other components separately): https://taiga.maykinmedia.nl/project/open-inwoner/issue/2709
src/open_inwoner/components/templates/components/Form/ChoiceListItem.html
Outdated
Show resolved
Hide resolved
+ data: the value of a form field field | ||
- index: the index of a for-loop when looping over choices | ||
- initial: the initial value of the field | ||
- input_type_radio: bool | if this is true, show radiobutton, else show checkbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's better to use input_type: str
and do {% choice_list_item ... input_type=radio %}
and {% if input_type == "radio" %}
respectively. This way the template and template tag could be extended to work with other input types (like switch). Just an idea, though; perhaps it's not worth the effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are (potentially) several issues:
- the "Communicatiekanaal" in the profile is at least misleading because it doesn't reflect the user's choice when they sign up or change their profile. However, I'm not sure if this should be addressed or how, since the choice only concerns notifications about zaak notificaties where action is required (there is no post for notifications about actions or messages)
- it would be nice if the radio was pre-selected according to the user's choice. So if I sign up with "Digitaal en per brief", the corresponding radio choice is pre-selected when I edit my profile.
e7c2716
to
286b3ca
Compare
Multi radio select design (lots of switching between decisions on whether to use icons or not)
taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2685
So needs to look like this, (but with the checkmark for Acties on the right instead of left):
Using the single radio Parent-select component just like these: https://github.com/maykinmedia/open-inwoner/pull/1043/files
Test:
http://localhost:8000/mijn-profiel/notificaties/
http://localhost:8000/mijn-profiel/register/necessary/
http://localhost:8000/kvk/branches/
If we ever need to implement the other vertical design (without the icons) in future, we can use this very same template in different ways, like this: