Test behavior of case search with multiple results #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a simple test to ensure we cover the (expectedly) rare case when cases are found in multiple backends. We can't currently cover the error cases well because we silence all client errors. Ideally we'd test this without error-silencing and using VCR, but that's for a later iteration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1354 +/- ##
=========================================
Coverage 95.13% 95.14%
=========================================
Files 999 999
Lines 36617 36723 +106
=========================================
+ Hits 34835 34939 +104
- Misses 1782 1784 +2 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Aug 15, 2024
| reverse( | ||
| "cases:case_detail", | ||
| kwargs={ | ||
| "object_id": "d8bbdeb7-770f-4ca9-b1ea-77b4730bf67d", |
There was a problem hiding this comment.
We have a utility for extracting UUIDs from URLs to avoid hard-coding like this:
from open_inwoner.utils.test import uuid_from_url
"object_id": uuid_from_url(self.zaak1["url"])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple test to ensure we cover the (expectedly) rare case when cases are found in multiple backends. We can't currently cover the error cases well because we silence all client errors. Ideally we'd test this without error-silencing and using VCR, but that's for a later iteration.