Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ZGW import/export service #1353

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add a ZGW import/export service #1353

merged 2 commits into from
Aug 16, 2024

Conversation

swrichards
Copy link
Collaborator

No description provided.

@swrichards swrichards force-pushed the add-zgw-import-export-service branch from 5a7cf90 to ba880b6 Compare August 15, 2024 13:49
@swrichards swrichards marked this pull request as ready for review August 15, 2024 13:52
@swrichards swrichards requested a review from pi-sigma August 15, 2024 13:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (b2aca0a) to head (8c58a8c).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1353      +/-   ##
===========================================
+ Coverage    95.13%   95.17%   +0.03%     
===========================================
  Files          999     1001       +2     
  Lines        36714    36921     +207     
===========================================
+ Hits         34929    35140     +211     
+ Misses        1785     1781       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi-sigma
pi-sigma requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Couple minor points/suggestions.

@swrichards swrichards force-pushed the add-zgw-import-export-service branch from ba880b6 to d082d62 Compare August 15, 2024 15:10
@swrichards swrichards requested a review from pi-sigma August 15, 2024 15:11
@swrichards swrichards requested a review from alextreme August 15, 2024 18:22
@swrichards swrichards force-pushed the add-zgw-import-export-service branch from d082d62 to b6532c7 Compare August 15, 2024 18:34
alextreme
alextreme requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, mag na het fixen gemerged worden

@swrichards swrichards force-pushed the add-zgw-import-export-service branch from b6532c7 to 8c58a8c Compare August 16, 2024 09:02
@alextreme alextreme merged commit 281d769 into develop Aug 16, 2024
20 checks passed
@alextreme alextreme deleted the add-zgw-import-export-service branch August 16, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swrichards @codecov-commenter @alextreme @pi-sigma