Make parameters of LimitedUploadFileField overridable #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1350 +/- ##
========================================
Coverage 95.11% 95.12%
========================================
Files 995 996 +1
Lines 36472 36517 +45
========================================
+ Hits 34692 34737 +45
Misses 1780 1780 ☔ View full report in Codecov by Sentry. |
pi-sigma
requested changes
Aug 15, 2024
3238ffc to
389a1eb
Compare
To allow for better re-use, it is desirable to make the parameters of the field overridable. A case in point is an upcoming change to process ZGW exports, which requires both different size limits and permissible mimetypes.
389a1eb to
eea5b97
Compare
pi-sigma
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for better re-use, it is desirable to make the parameters of the field overridable. A case in point is an upcoming change to process ZGW exports, which requires both different size limits and permissible mimetypes.