[#2563] Fix enable variables for setup configuration #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
389d68b to
c1180a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1349 +/- ##
========================================
Coverage 95.13% 95.13%
========================================
Files 999 999
Lines 36714 36721 +7
========================================
+ Hits 34929 34936 +7
Misses 1785 1785 ☔ View full report in Codecov by Sentry. |
1abd71b to
db3f369
Compare
swrichards
requested changes
Aug 15, 2024
db3f369 to
dd7ac0f
Compare
swrichards
approved these changes
Aug 15, 2024
|
@pi-sigma check the failing test |
|
@alextreme good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enable_config_settingvariables had the wrong type of default value, preventing the configuration steps from being disabled becauseenable_settingwould always evaluate toTrue.Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2563